keyboard/qmk-keychron-q3-colemak-dh
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix swap-hands tapping.

Browse Source 
This is an inelegant hack for #2522 but makes things work. Basically we give `action.c` a chance to handle the hold event early so that we can swap the keyboard for later keys. Later, to allow the hold to happen again quickly we nuke the key record so that tapping is reset. I tried to find a cleaner way, honestly.
This commit is contained in:
Joe Wasson
2018-03-12 10:22:49 -07:00
committed by Jack Humbert
parent 23ac2a02ef
commit 5d771039ad
4 changed files with 50 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tmk_core/common/action_tapping.c
View File

@ -263,7 +263,7 @@ bool process_tapping(keyrecord_t *keyp)
return true;
}
} else {
// FIX: process_aciton here?
// FIX: process_action here?
// timeout. no sequential tap.
debug("Tapping: End(Timeout after releasing last tap): ");
debug_event(event); debug("\n");
@ -277,6 +277,7 @@ bool process_tapping(keyrecord_t *keyp)
if (event.pressed && is_tap_key(event.key)) {
debug("Tapping: Start(Press tap key).\n");
tapping_key = *keyp;
process_record_tap_hint(&tapping_key);
waiting_buffer_scan_tap();
debug_tapping_key();
return true;