Fix LED configuration for PS2AVRGB boards (#7989)

* Fix LED configuration for PS2AVRGB boards

* Undo backlight on state changes

keyboards/ares/ares.c

@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/ares/config.h

@@ -39,6 +39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

keyboards/bfake/bfake.c

@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/bfake/config.h

@@ -39,6 +39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

keyboards/db/db63/config.h

@@ -41,4 +41,3 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
-

keyboards/donutcables/budget96/budget96.c

@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/donutcables/budget96/config.h

@@ -39,4 +39,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS

keyboards/eve/meteor/meteor.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/exclusive/e6v2/le_bmc/le_bmc.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/exent/config.h

@@ -41,6 +41,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

keyboards/exent/exent.c

@@ -25,16 +25,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/facew/config.h

@@ -39,4 +39,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS

keyboards/facew/facew.c

@@ -25,13 +25,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/ft/mars80/config.h

@@ -40,6 +40,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

keyboards/ft/mars80/mars80.c

@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/gray_studio/hb85/config.h

@@ -33,3 +33,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define RGBLED_NUM 5
 #define RGBLIGHT_ANIMATIONS
+
+#define BACKLIGHT_PIN D4
+#define BACKLIGHT_LEVELS 3

keyboards/gray_studio/hb85/hb85.c

@@ -27,16 +27,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/j80/j80.c

@@ -16,10 +16,21 @@
 
 #include "j80.h"
 
+void keyboard_pre_init_kb(void) {
+    led_init_ports();
+    keyboard_pre_init_user();
+}
+
+void led_init_ports(void) {
+    setPinOutput(D0);
+    setPinOutput(D1);
+    setPinOutput(D6);
+}
+
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, led_state.caps_lock);
         writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
         writePin(D6, led_state.scroll_lock);
     }
     return true;

keyboards/jc65/v32a/v32a.c

@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/kbdfans/kbdpad/mk1/mk1.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D0);
-    writePinHigh(D0);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
     }
     return true;
 }

keyboards/mehkee96/mehkee96.c

@@ -25,14 +25,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/panc60/panc60.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/pearl/pearl.c

@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/percent/canoe/canoe.c

@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/percent/skog/skog.c

@@ -27,14 +27,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/percent/skog_lite/skog_lite.c

@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/singa/singa.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/tgr/alice/alice.c

@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/tgr/jane/jane.c

@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/unikorn/unikorn.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/winkeyless/bface/bface.c

@@ -25,16 +25,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/winkeyless/bmini/bmini.c

@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/winkeyless/bminiex/bminiex.c

@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

keyboards/ymd75/ymd75.c

@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/ymd96/ymd96.c

@@ -26,14 +26,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/ymdk/bface/bface.c

@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

keyboards/ymdk_np21/ymdk_np21.c

@@ -25,7 +25,6 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D0);
-    writePinHigh(D0);
 }
 
 bool led_update_kb(led_t led_state) {