Align our subprocess usage with current best practices. (#12940)
* Align our subprocess usage with current best practices. * remove unused import * Apply suggestions from code review Co-authored-by: Ryan <fauxpark@gmail.com> * fix the cpp invocation for older python * allow for unprompted installation * make sure qmk new-keyboard works on windows Co-authored-by: Ryan <fauxpark@gmail.com>
This commit is contained in:
@ -2,6 +2,13 @@
|
||||
|
||||
QMK_FIRMWARE_DIR=$(cd -P -- "$(dirname -- "$0")/.." && pwd -P)
|
||||
QMK_FIRMWARE_UTIL_DIR=$QMK_FIRMWARE_DIR/util
|
||||
if [ "$1" = "-y" ]; then
|
||||
SKIP_PROMPT='-y'
|
||||
MSYS2_CONFIRM='--noconfirm'
|
||||
else
|
||||
SKIP_PROMPT=''
|
||||
MSYS2_CONFIRM=''
|
||||
fi
|
||||
|
||||
case $(uname -a) in
|
||||
*Darwin*)
|
||||
|
Reference in New Issue
Block a user