keyboard/qmk-keychron-q3-colemak-dh
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vial/encoders: replace 254 magic with a constant

Browse Source
This commit is contained in:
Ilya Zhuravlev 2021-01-03 09:12:16 -05:00
parent 32984ea0c9
commit e2447a0eea
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
quantum/dynamic_keymap.c
View File

@ -200,7 +200,7 @@ uint16_t keymap_key_to_keycode(uint8_t layer, keypos_t key) {
#endif #endif
#ifdef VIAL_ENCODERS_ENABLE #ifdef VIAL_ENCODERS_ENABLE
if (key.row == 254 && key.col == 254) if (key.row == VIAL_ENCODER_MATRIX_MAGIC && key.col == VIAL_ENCODER_MATRIX_MAGIC)
return g_vial_magic_keycode_override; return g_vial_magic_keycode_override;
#endif #endif

4
quantum/vial.c
View File

@ -163,10 +163,10 @@ static void exec_keycode(uint16_t keycode) {
g_vial_magic_keycode_override = keycode; g_vial_magic_keycode_override = keycode;
action_exec((keyevent_t){ action_exec((keyevent_t){
.key = (keypos_t){.row = 254, .col = 254}, .pressed = 1, .time = (timer_read() | 1) /* time should not be 0 */ .key = (keypos_t){.row = VIAL_ENCODER_MATRIX_MAGIC, .col = VIAL_ENCODER_MATRIX_MAGIC}, .pressed = 1, .time = (timer_read() | 1) /* time should not be 0 */
}); });
action_exec((keyevent_t){ action_exec((keyevent_t){
.key = (keypos_t){.row = 254, .col = 254}, .pressed = 0, .time = (timer_read() | 1) /* time should not be 0 */ .key = (keypos_t){.row = VIAL_ENCODER_MATRIX_MAGIC, .col = VIAL_ENCODER_MATRIX_MAGIC}, .pressed = 0, .time = (timer_read() | 1) /* time should not be 0 */
}); });
} }

3
quantum/vial.h
View File

@ -41,3 +41,6 @@ enum {
vial_unlock_poll = 0x07, vial_unlock_poll = 0x07,
vial_lock = 0x08, vial_lock = 0x08,
}; };
/* Fake encoder position in keyboard matrix, can't use 255 as that is immediately rejected by IS_NOEVENT */
#define VIAL_ENCODER_MATRIX_MAGIC 254