keyboard/qmk-keychron-q3-colemak-dh
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

contra, fractal: Remove wrongly copypasted pin E6 manipulation code (#14818)

Browse Source 
Apparently the default keymaps for `contra` and `fractal` were derived
from some `planck` keymap which contained code to control the status LED
in the implementation of the `BACKLIT` custom keycode.  Unfortunately,
the code to control the LED manipulated the `E6` pin directly, and it
was copied without changes, but the `contra` and `fractal` boards use
the `E6` pin in the matrix, therefore pressing the key mapped to
`BACKLIT` resulted in phantom keypresses for all keys in the
corresponding column.
This commit is contained in:
Sergey Vlasov 2021-10-14 16:41:30 +03:00 committed by GitHub
parent 04cf161aa0
commit f9f3a11c20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
keyboards/contra/keymaps/default/keymap.c
View File

@ -222,10 +222,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
#ifdef BACKLIGHT_ENABLE #ifdef BACKLIGHT_ENABLE
backlight_step(); backlight_step();
#endif #endif
PORTE &= ~(1<<6);
} else { } else {
unregister_code(KC_RSFT); unregister_code(KC_RSFT);
PORTE |= (1<<6);
} }
return false; return false;
break; break;

2
keyboards/fractal/keymaps/default/keymap.c
View File

@ -213,10 +213,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
#ifdef BACKLIGHT_ENABLE #ifdef BACKLIGHT_ENABLE
backlight_step(); backlight_step();
#endif #endif
PORTE &= ~(1<<6);
} else { } else {
unregister_code(KC_RSFT); unregister_code(KC_RSFT);
PORTE |= (1<<6);
} }
return false; return false;
break; break;