Fix menu navigation, informational items, and boolean editing
This commit is contained in:
8 files changed
+355
-24
No files matched your search
+146
-4
@@ -49,10 +49,152 @@ func TestMenuNil(t *testing.T) {
|
||||
|
||||
func TestMenuNotPointer(t *testing.T) {
|
||||
var settings testSettings
|
||||
menu, err := New(settings, 4, nil)
|
||||
_, err := New(settings, 4, nil)
|
||||
if err == nil {
|
||||
t.Fatal("expected error for an unaddressable struct")
|
||||
}
|
||||
}
|
||||
|
||||
func TestInformationalItemsRemainNavigable(t *testing.T) {
|
||||
data := struct {
|
||||
LoadAverage string
|
||||
LocalTime string
|
||||
}{LoadAverage: "0.12 0.10 0.08", LocalTime: "12:00"}
|
||||
m, err := New(&data, 4, nil)
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, position := range []int{1, 2} {
|
||||
m.Position = position
|
||||
m.ToggleEdit()
|
||||
if m.IsEditing() {
|
||||
t.Fatal("informational item entered edit mode")
|
||||
}
|
||||
m.Change(-position)
|
||||
if m.ActiveItem().Value != Back {
|
||||
t.Fatal("cannot navigate back after selecting information")
|
||||
}
|
||||
}
|
||||
if data.LoadAverage != "0.12 0.10 0.08" || data.LocalTime != "12:00" {
|
||||
t.Fatal("informational values changed")
|
||||
}
|
||||
}
|
||||
|
||||
func TestSubmenuBackPreservesParentPosition(t *testing.T) {
|
||||
var data testSettings
|
||||
root, err := New(&data, 4, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
root.Position = 2
|
||||
child := root.EnterSubMenu()
|
||||
if child == nil {
|
||||
t.Fatal("missing submenu")
|
||||
}
|
||||
if child.ActiveItem().Value != Back {
|
||||
t.Fatal("submenu should initially select Back")
|
||||
}
|
||||
if got := child.ExitSubMenu(); got != root || got.Position != 2 {
|
||||
t.Fatal("Back did not restore parent selection")
|
||||
}
|
||||
root.Position = 0
|
||||
root.ToggleEdit()
|
||||
if root.IsEditing() {
|
||||
t.Fatal("Back entered edit mode")
|
||||
}
|
||||
if root.ExitSubMenu() != nil {
|
||||
t.Fatal("root should exit settings")
|
||||
}
|
||||
}
|
||||
|
||||
func TestStringOptionsLargeNegativeDelta(t *testing.T) {
|
||||
data := struct {
|
||||
Sleep string `options:"5min,15min,hour,day"`
|
||||
}{Sleep: "hour"}
|
||||
m, err := New(&data, 4, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m.Position = 1
|
||||
m.ToggleEdit()
|
||||
if !m.IsEditing() {
|
||||
t.Fatal("option item should be editable")
|
||||
}
|
||||
m.Change(-11)
|
||||
if data.Sleep != "day" {
|
||||
t.Fatalf("got %q, want day", data.Sleep)
|
||||
}
|
||||
}
|
||||
|
||||
func TestUint8DoesNotWrap(t *testing.T) {
|
||||
data := struct{ Contrast uint8 }{Contrast: 255}
|
||||
m, err := New(&data, 4, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m.Position = 1
|
||||
m.ToggleEdit()
|
||||
m.Change(1)
|
||||
if data.Contrast != 255 {
|
||||
t.Fatal("contrast wrapped above maximum")
|
||||
}
|
||||
data.Contrast = 0
|
||||
m.Change(-1)
|
||||
if data.Contrast != 0 {
|
||||
t.Fatal("contrast wrapped below minimum")
|
||||
}
|
||||
}
|
||||
|
||||
func TestMinimumPageSize(t *testing.T) {
|
||||
var data testSettings
|
||||
m, err := New(&data, 0, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if m.PageSize() != 1 {
|
||||
t.Fatal("page size must be positive")
|
||||
}
|
||||
m.SetPageSize(-1)
|
||||
if m.Items[1].SubMenu.PageSize() != 1 {
|
||||
t.Fatal("submenu page size must be positive")
|
||||
}
|
||||
}
|
||||
|
||||
func TestBooleanEditingUsesDirection(t *testing.T) {
|
||||
for _, initial := range []bool{false, true} {
|
||||
data := struct{ Enabled bool }{Enabled: initial}
|
||||
m, err := New(&data, 4, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m.Position = 1
|
||||
m.ToggleEdit()
|
||||
for _, delta := range []int{1, 1, 3, 0, -1, -1, -4, 0, 1} {
|
||||
before := data.Enabled
|
||||
m.Change(delta)
|
||||
want := delta > 0
|
||||
if delta == 0 {
|
||||
want = before
|
||||
}
|
||||
if data.Enabled != want {
|
||||
t.Fatalf("initial=%v delta=%d: got %v, want %v", initial, delta, data.Enabled, want)
|
||||
}
|
||||
if m.Position != 1 || !m.IsEditing() {
|
||||
t.Fatal("rotating left boolean edit mode")
|
||||
}
|
||||
}
|
||||
m.ToggleEdit()
|
||||
if m.IsEditing() || !data.Enabled {
|
||||
t.Fatal("confirming did not preserve the selected value")
|
||||
}
|
||||
m.Change(-1)
|
||||
if m.Position != 0 || !data.Enabled {
|
||||
t.Fatal("navigation changed the confirmed value")
|
||||
}
|
||||
m.Change(1)
|
||||
m.ToggleEdit()
|
||||
if !data.Enabled {
|
||||
t.Fatal("reopening edit mode reset the value")
|
||||
}
|
||||
}
|
||||
|
||||
t.Logf("menu: %#+v", menu)
|
||||
}
|
||||
Reference in new issue
Block a user