Fix menu navigation, boolean editing, and unexpected exits #3

Open
maze wants to merge 2 commits from fix/menu-navigation into main
pull from: fix/menu-navigation
Owner

Short button presses could be misclassified as long presses because evdev microseconds were interpreted as nanoseconds. The input reader also assumed 32-bit event records on 64-bit Linux. These failures could close settings unexpectedly, while unchanged menus forced hardware refreshes every frame.

  • Decode 32-bit and 64-bit Linux input events correctly, ignore key repeats and contact bounce, and require 750 ms for a long press.
  • Dispatch each input event to one handler and redraw the menu only when changed.
  • Synchronize menu state after long press, preserve parent selection, and return to the previously active screen when settings close.
  • Keep system information read-only. Left unchecks booleans, right checks them, and pressing confirms the session value.
  • Prevent negative string-option indexes, brightness wraparound, zero page sizes, and reflection panics from unsupported constructor inputs.

Validation: input and menu-model regression tests executed with the race detector. Menu, layout, widget, and controller tests also executed with the race detector using a temporary macOS overlay whose wireless stubs panic if called; production hardware code was not replaced. Affected packages cross-compile for Linux ARM64, and input tests cross-compile for Linux ARM. git diff --check passes.

Physical encoder and display verification remains outstanding.

Short button presses could be misclassified as long presses because evdev microseconds were interpreted as nanoseconds. The input reader also assumed 32-bit event records on 64-bit Linux. These failures could close settings unexpectedly, while unchanged menus forced hardware refreshes every frame. - Decode 32-bit and 64-bit Linux input events correctly, ignore key repeats and contact bounce, and require 750 ms for a long press. - Dispatch each input event to one handler and redraw the menu only when changed. - Synchronize menu state after long press, preserve parent selection, and return to the previously active screen when settings close. - Keep system information read-only. Left unchecks booleans, right checks them, and pressing confirms the session value. - Prevent negative string-option indexes, brightness wraparound, zero page sizes, and reflection panics from unsupported constructor inputs. Validation: input and menu-model regression tests executed with the race detector. Menu, layout, widget, and controller tests also executed with the race detector using a temporary macOS overlay whose wireless stubs panic if called; production hardware code was not replaced. Affected packages cross-compile for Linux ARM64, and input tests cross-compile for Linux ARM. git diff --check passes. Physical encoder and display verification remains outstanding.
maze added 2 commits 2026-10-29 19:07:36 +01:00
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/menu-navigation:fix/menu-navigation
git checkout fix/menu-navigation
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: maze/beatglow#3